Set batch=False in OVSSwitch for low-level API
If you try to use the low-level API, you are probablynot going to call batchStartup()! So, we set batch=Falseby default. This means that buildFromTopo() needs to setit to True, so we add a bit of irritatingly complex machinery...
Fix OVS user switch (remove unnecessary % parameter)
cluster: add batchStartup/Shutdown, cleanup
Remove debug print lines
Clarify which intf pair failed and raise exception
Merge OVSBatch into OVSSwitch
Note that we are changing the interface of batchStartup/Shutdownslightly so that the method can choose not to start some of theswitches. We might wish to refine this a bit...
Don't clean up links that may have been dumped into root NS.
This should rarely happen - in the usual case, either thelinks will be shut down by Mininet.stop(), or the interfaceswill be deleted by node.stop( deleteIntfs=True ), or thelinks or interfaces will be explicitly deleted or stopped...
make 'ovs-vsctl' string symmetric
Fix super() typo
Clean up - TCReapply still broken!
Remove shared reconnectms, improve self.started
We still need to set it in batchShutdown()
Refactor for compatibility with isOldOVS() == True
First crack at setting controller backoff in single command
errRun: add debug( results )
Add debug(cmd) to errRun()
Add OVSBatch class (experimental)
This implements batch startup for OVS switches.
Clarify bandwidth limit for TCIntfs
In the future, we would like to support higher bandwidthlimits for TCIntfs, but we'll probably need to adjust someof the parameters dynamically.
Exit poll loop on POLLHUP or anything unexpected
In my opinion, we really shouldn't even get POLLHUP, butwe do. In case we get anything else odd, quite polling onthat fd.
Fix polling in errRun
It's tricky to get this right, but basically we want to readif there is something to read; if not, we want to check forEOF.
Return correct success condition in cgroupDel
Without this, we end up retrying until we fail, insteadof returning immediately on success!
Call delete() in link.stop() ; warn on exited node.cmd()
We should think a bit about the semantics that we want here.The comments say "stop and clean up link" so perhaps that'swhat we want. However, we could also imagine stop stoppingforwarding on the link (and possibly allowing restarts)....
2.2.0 -> 2.2.0+
Pass code check
Add stp param to OVS and connected() to OVSBridge
This allows --switch ovsbr,stp=True to work correctly
OVSLink: use isinstance() to detect OVSSwitch subclasses
Merge del-br into cmd, and add reconnectms param
With newer versions of OVS, this allows us to set up a switchwith a single OVS command (if reconnectms is zero.) If reconnectmsis specified, then it slows things down slightly (but not much.)
pass code check
Stub out RemoteOVSSwitch.batchShutdown()
Eventually we should implement true batch shutdown.In the mean time, we just ignore it. Note there's no goodway that I know of for a subclass to remove a superclassmethod, so we changed the protocol a bit to require a return...
Fix indentation error
Don't stop switches that we've already stopped.
Note that this also changes the way that links are deleted;the reason is that the batch shutdown doesn't currently deletethe links, but OVSSwitch.stop() does. We may wish to revisitthis in the future.
Add comment about redundant intf.delete()
customize makeIntfPair to eliminate fastIntfPair
Add addresses to fastIntfPair() and fix codecheck
Update comment to reflect OVS patch link limits
add fastIntfPair to speed up link creation
use isinstance( intf, OVSIntf )
Add OVSLink/--link ovs, which uses OVS patch links when possible
Revert to using OVS default OpenFlow versions.
It makes sense to follow Open vSwitch's lead here.OVS 2.3 enables OpenFlow 1.0 through 1.3 by default.OVS 2.0 has incomplete support for 1.3, but you can enableit with protocols=OpenFlow13
Set OVSSwitch default protocols to OpenFlow10,OpenFlow13
For OVS versions 1.9 or earlier, this setting is ignored.
Fix code minor code check errors
Correctly set controller backoff for OVS.
Also report connected in standalone/bridge mode
2.2.0rc1 -> 2.2.0
2.2.0rc1 -> 2.2.0rc2
Basically no changes except for whitespace and satisfying pep8.
Spacing tweaks for pep8 checker
version -> 2.2.0rc1 and update copyright date
Restore missing space in RT_GROUP_SCHED message
call to run() should be to runCmd()
warn -> debug in connected; change IVS class comment
Change from numeric to symbolic pylint error codes
Maybe this is better - maybe not. ;-p
More pylint changes
Fix missing imports
Fixing pylint errors
Fix pylint error
Add cleanup and fix pylint errors
Fix pylint errors
Reorganize and pass pylint
Remove trailing whitespace. ;-/
Set default route in one cmd line to avoid dc'ing root NS
Usually you won't want to create a node in the root namespace,and usually you won't want to use the Mininet API to set your(real) default route, but if you do then you will probably wantto use a single command line to avoid disconnecting an SSH...
Updating NAT class to use gateway interface
Also, passing CLI args to NAT constructor
Merge pull request #450 from mininet/sw-cmd
adding deleteIntfs option to switches and corresponding CLI command
Minor code cleanup
Make pylint happier for no particular reason
Remove unused imports
Fix undefined sleep()
Fix typo. ;-p
type( foo ) is bar -> isinstance( foo, bar )
use isinstance( obj, basestring) to allow unicode strings
explicit param call in cli command
Merge pull request #241 from moijes12/fix44
(pending) Create test_switchdpidassignment.py
IVSSwitch: turn off verbose logging by default
Most users don't need this much logging and it slows down the switch.
Add setup() and dpctl() methods for LinuxBridge
Also adds docstrings.Fixes #422
Revert to old "Adding controller" message
raise exception when no prefixLen is set
Remove ^S which was in this file (thanks emacs bindings)
Don't blow away parameters that aren't specified in node.config()
2.2.0b0 -> 2.2.0b1
Clarify MultiTopo docstrs and copy addLInk opts
Note: it's a bit confusing, but we need to copy the linkparameter dicts (since we update them with node info), but wecan share the node dicts. Perhaps we should copy the nodedicts as well...
Merge pull request #434 from cdburkard/patches/cluster_x11
wrap the title string in quotes so that bash interprets it correctly
Add seconds option to iperf()
Merge pull request #433 from mininet/devel/update-version-2.2b0
Initial update of README, text files and versions for 2.2.0b0
Merge pull request #416 from mininet/devel/multitopo
Multi-link topology support
Use 2.2.0b0 for consistency with earlier Mininet releases
Add a few clarifying comments
Make port1, port2 truly optional and don't pass them to Link()
Get rid of paramDict and simplify things a bit
Merge pull request #432 from mininet/devel/fallback
Fall back to OVSBridge if no controller is available for default switch
Draft update for Mininet 2.2b0
Raise exception if DefaultController cannot find a controller
Return controller correctly.
Don't check rt_runtime_us for CFS scheduler
Reorganize CFS and RT default/error conditions.
Move RT check into its own method, and save value.
Merge pull request #419 from cdburkard/patches/rt_failure_output
fix silent failures when rt cannot be assigned - will follow up on this