« Previous | Next » 

Revision b78b99b6

IDb78b99b695e2ab692d43f94621eea37fbfce67b3
Parent a1bff4b0
Child 327af97c

Added by Bob Lantz over 3 years ago

monitor() should return on timeout; docstring changes

It appears that read() has been blocking for some time,
so for now it makes sense to change the documentation to
match the functionality!

It's not entirely clear if monitor() expects this functionality.
However, with the current blocking read() semantics, it should
definitely return (and not call read()) on a poll timeout.

So, we now return the poll() result from waitReadable() (which
should have done this already probably) and check it. In the
fullness of time, we still need to revisit the whole I/O API
and make sure that it is consistent, sane, correctly documented,
and used correctly in the examples.

See #588 for more comments.

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences