Statistics
| Branch: | Revision:

ffmpeg / libavformat @ bd51c013

# Date Author Comment
bd51c013 03/22/2009 04:10 PM Aurelien Jacobs

handle id3v2 'genre' tag formated as '%d'

Originally committed as revision 18145 to svn://svn.ffmpeg.org/ffmpeg/trunk

2121b160 03/22/2009 01:05 PM Ronald S. Bultje

Remove alpha channel from default colorspace tables, since it is unused. See
"qtpalette.h" thread on mailinglist.

Originally committed as revision 18144 to svn://svn.ffmpeg.org/ffmpeg/trunk

e6b09f43 03/22/2009 12:47 PM Ronald S. Bultje

Add a @todo with a comment from Kostya so we don't forget to optimize that at
some point in the future.

Originally committed as revision 18142 to svn://svn.ffmpeg.org/ffmpeg/trunk

c21fbefb 03/22/2009 07:40 AM Kostya Shishkov

Add AURA 1 and 2 codec IDs and register their FOURCCs

Originally committed as revision 18141 to svn://svn.ffmpeg.org/ffmpeg/trunk

5c5776e1 03/22/2009 03:52 AM Baptiste Coudurier

allocate tracks instead of using MAX_STREAMS

Originally committed as revision 18140 to svn://svn.ffmpeg.org/ffmpeg/trunk

08a5b4e9 03/22/2009 02:47 AM Baptiste Coudurier

since code now use get_bits_long, allocate padding buffer

Originally committed as revision 18138 to svn://svn.ffmpeg.org/ffmpeg/trunk

5f01c125 03/22/2009 02:04 AM Baptiste Coudurier

avoid creating a new stream not referenced in pmt since it cannot be associated to a program, fix issue 835

Originally committed as revision 18137 to svn://svn.ffmpeg.org/ffmpeg/trunk

a0dd3c00 03/21/2009 11:29 PM Baptiste Coudurier

reset codec width/height for h264 forcing decoder to parse extradata

Originally committed as revision 18134 to svn://svn.ffmpeg.org/ffmpeg/trunk

cc9aced3 03/21/2009 09:02 PM Ronald S. Bultje

Remove slash-skipping code because the function called right after that
statement (get_word_sep()) already does that all by itself. See summary in
"[PATCH] rtsp.c small cleanups" thread on mailinglist.

Originally committed as revision 18128 to svn://svn.ffmpeg.org/ffmpeg/trunk

78f731de 03/21/2009 09:00 PM Ronald S. Bultje

Reindent something where a if () --> { <-- is on a newline rather than on the
same line as the if. See summary in "[PATCH] rtsp.c small cleanups" thread on
mailinglist.

Originally committed as revision 18127 to svn://svn.ffmpeg.org/ffmpeg/trunk

7d09a993 03/21/2009 08:59 PM Ronald S. Bultje

Free metadata if already allocated; fixes a memleak if the header occurs twice
in a stream (e.g. malicious input, broken file, etc.). See summary in "[PATCH]
rtsp.c small cleanups" thread on mailinglist.

Originally committed as revision 18126 to svn://svn.ffmpeg.org/ffmpeg/trunk

6a8c8b36 03/21/2009 08:58 PM Ronald S. Bultje

Fix silly bug in hex_to_data() where it compares a string pointer for whether
it is '\0' rather than its content (char *p; if (p '\0') instead of if
(*p '\0')). See summary in "[PATCH] rtsp.c small cleanups" thread on
mailinglist.

Originally committed as revision 18125 to svn://svn.ffmpeg.org/ffmpeg/trunk

64917dd3 03/21/2009 08:56 PM Ronald S. Bultje

Remove useless comment about something that is deprecated. See summary in
"[PATCH] rtsp.c small cleanups" thread on mailinglist.

Originally committed as revision 18124 to svn://svn.ffmpeg.org/ffmpeg/trunk

36aa7bc2 03/21/2009 08:55 PM Ronald S. Bultje

Use skip_spaces() in the "redir" demuxer instead of "while (isspace(&p)) p++".
See summary in "[PATCH] rtsp.c small cleanups" thread on mailinglist.

Originally committed as revision 18123 to svn://svn.ffmpeg.org/ffmpeg/trunk

1ef36a70 03/21/2009 08:54 PM Ronald S. Bultje

Merge functional code from get_word() and get_word_sep() into a single
function, since they both do approximately the same thing. At the same time,
remove redir_isspace() altogether since code elsewhere (including
get_word_sep()) uses strchr() for the same purpose. See summary in "[PATCH]...

7e726132 03/21/2009 08:46 PM Ronald S. Bultje

Allow (and parse) incoming server messages (notices) interleaved with TCP
data packets or in addition to UDP data packets, over the RTSP/TCP connection.
See discussion in [PATCH] rtsp.c: read TCP server notifications/messages"
thread on mailinglist.

Originally committed as revision 18121 to svn://svn.ffmpeg.org/ffmpeg/trunk

9c610b76 03/21/2009 08:44 PM Ronald S. Bultje

Add a @todo item to use ByteIOContext instead of URLContext at some point in
the future, requested by Luca in "[PATCH] rtsp.c: read TCP server
notifications/messages" thread.

Originally committed as revision 18120 to svn://svn.ffmpeg.org/ffmpeg/trunk

8b9794e5 03/21/2009 08:34 PM Ronald S. Bultje

Remove index writing in RM muxer, since it is broken (multiple streams per
single index chunk) and is always empty anyway. See "[PATCH] rmenc.c: remove
index writing" thread.

Originally committed as revision 18119 to svn://svn.ffmpeg.org/ffmpeg/trunk

83c0ba3d 03/21/2009 07:19 PM Ronald S. Bultje

Don't allow to sync on packets of zero-size length, since these are never
valid. See "[PATCH] rmdec.c: prevent zero-length packets" thread.

Originally committed as revision 18118 to svn://svn.ffmpeg.org/ffmpeg/trunk

e75e603c 03/21/2009 07:18 PM Ronald S. Bultje

Move "- 12" statement up a bit. See "[PATCH] rmdec.c: prevent zero-length
packets" thread.

Originally committed as revision 18117 to svn://svn.ffmpeg.org/ffmpeg/trunk

e1dc16ae 03/21/2009 03:52 PM Daniel Verkamp

Make Smacker audio decoder output audio in original bit depth

Patch by Daniel Verkamp
($firstname) at (three-letter file extension for drivers in Win 3.1) dot (nu)

Thread: [PATCH] Smacker: Output audio in original bit depth

Originally committed as revision 18111 to svn://svn.ffmpeg.org/ffmpeg/trunk

1a4ab332 03/21/2009 08:22 AM David Conrad

Reindent

Originally committed as revision 18102 to svn://svn.ffmpeg.org/ffmpeg/trunk

6e6abd02 03/21/2009 08:22 AM David Conrad

Fix Speex header parsing in ogg demuxer

Originally committed as revision 18101 to svn://svn.ffmpeg.org/ffmpeg/trunk

1fa9726c 03/21/2009 08:03 AM David Conrad

Document ogg_codec's header function

Originally committed as revision 18100 to svn://svn.ffmpeg.org/ffmpeg/trunk

be2a6e2f 03/21/2009 07:36 AM Baptiste Coudurier

fix compilation when DEBUG_SEEK is defined

Originally committed as revision 18099 to svn://svn.ffmpeg.org/ffmpeg/trunk

92a0f338 03/21/2009 07:35 AM Baptiste Coudurier

fix valid seeking range

Originally committed as revision 18098 to svn://svn.ffmpeg.org/ffmpeg/trunk

b4800b8b 03/21/2009 12:50 AM Baptiste Coudurier

protect realloc overflow

Originally committed as revision 18088 to svn://svn.ffmpeg.org/ffmpeg/trunk

29b0d168 03/21/2009 12:49 AM Justin Ruggles

seek backwards 4 bytes if 'fLaC' marker is not found

Originally committed as revision 18086 to svn://svn.ffmpeg.org/ffmpeg/trunk

effcedf7 03/20/2009 05:23 PM Daniel Verkamp

PCX encoder that handles 1-, 8-, and 24-bpp pixfmts.

Patch by Daniel Verkamp, daniel drv nu

Originally committed as revision 18077 to svn://svn.ffmpeg.org/ffmpeg/trunk

7c45723a 03/20/2009 01:44 AM Baptiste Coudurier

resync ffm if error in stream

Originally committed as revision 18065 to svn://svn.ffmpeg.org/ffmpeg/trunk

21c6438f 03/20/2009 01:39 AM Baptiste Coudurier

typo, fix eof check

Originally committed as revision 18064 to svn://svn.ffmpeg.org/ffmpeg/trunk

b9edbe99 03/20/2009 01:23 AM Baptiste Coudurier

do not write ffm write index by default, detect if file is being written and return EOF

Originally committed as revision 18063 to svn://svn.ffmpeg.org/ffmpeg/trunk

cf16c17a 03/20/2009 01:22 AM Ronald S. Bultje

Add byte reordering for the SIPRO audio codec. See "rmdec.c: add SIPR codec
try #2" thread. Patch originally by Vladimir Voroshilov.

Originally committed as revision 18062 to svn://svn.ffmpeg.org/ffmpeg/trunk

e9fce261 03/20/2009 01:11 AM Ronald S. Bultje

Assign the x-pf-asf payload string to be decoded by rtp_asf.c, and add a
SDP line handler that parses the streamID in the SDP so that ASF stream
data can be matched to their respective streams in the RTSP demuxer. See
"[PATCH] RTSP-MS 12/15: ASF payload support" thread on mailinglist....

87657891 03/19/2009 09:57 PM Baptiste Coudurier

set avi fsize to INT64_MAX if riff tag end is not set and file size is not available

Originally committed as revision 18052 to svn://svn.ffmpeg.org/ffmpeg/trunk

3a560188 03/19/2009 09:54 PM Baptiste Coudurier

move max analyze duration check before considering new packet

Originally committed as revision 18051 to svn://svn.ffmpeg.org/ffmpeg/trunk

23d9cc45 03/19/2009 09:46 PM Ramiro Polla

Support raw TrueHD files

Originally committed as revision 18049 to svn://svn.ffmpeg.org/ffmpeg/trunk

9ba4821d 03/19/2009 09:23 PM Ramiro Polla

Split TrueHD decoder from MLP

Originally committed as revision 18045 to svn://svn.ffmpeg.org/ffmpeg/trunk

5c3d507f 03/19/2009 06:13 PM Alex Converse

MOV: Use the AOT enum for the mp4_audio_types mapping.

Originally committed as revision 18044 to svn://svn.ffmpeg.org/ffmpeg/trunk

b8b00d94 03/18/2009 02:03 PM Reimar Döffinger

Rename GUID typedef to ff_asf_guid to fix MinGW compilation failure
(GUID is also defined, but differently, in Windows headers).

Originally committed as revision 18032 to svn://svn.ffmpeg.org/ffmpeg/trunk

4d0c3dc0 03/18/2009 01:17 PM Reimar Döffinger

Add a special guidcmp function to compare ASF guids, to avoid the many
duplicated sizeof(GUID).

Originally committed as revision 18030 to svn://svn.ffmpeg.org/ffmpeg/trunk

79ff11d7 03/17/2009 06:35 PM Ronald S. Bultje

Fix wrong @file tag.

Originally committed as revision 18026 to svn://svn.ffmpeg.org/ffmpeg/trunk

c4a3d032 03/17/2009 12:35 PM Ronald S. Bultje

Reindent after r18023.

Originally committed as revision 18024 to svn://svn.ffmpeg.org/ffmpeg/trunk

1a30d541 03/17/2009 12:34 PM Ronald S. Bultje

Add RTP/ASF header parsing, which is part of the SDP of these streams. See
patch discussion in "[PATCH] RTSP-MS 10/15: ASF header parsing" thread.

Originally committed as revision 18023 to svn://svn.ffmpeg.org/ffmpeg/trunk

6d050dd6 03/17/2009 12:27 PM avcoder

cosmetics: fix indentation, patch by avcoder, ffmpeg gmail com

Originally committed as revision 18022 to svn://svn.ffmpeg.org/ffmpeg/trunk

2ac736a6 03/16/2009 08:49 PM Reimar Döffinger

Extend mov edit list support to work for a first padding entry with
time == -1 and duration. Complicated since time is relative to stream,
duration relative to container time base.

Originally committed as revision 18019 to svn://svn.ffmpeg.org/ffmpeg/trunk

c3df4a3b 03/16/2009 08:22 PM Måns Rullgård

rmdec: fix crash at end of file

Originally committed as revision 18018 to svn://svn.ffmpeg.org/ffmpeg/trunk

d0dab0ec 03/16/2009 04:24 PM Alex Converse

Cosmetics: Re-indent after last commit

Originally committed as revision 18017 to svn://svn.ffmpeg.org/ffmpeg/trunk

bd27eed6 03/16/2009 04:14 PM Alex Converse

MOV: Support stz2 "Compact Sample Size Box"

Originally committed as revision 18016 to svn://svn.ffmpeg.org/ffmpeg/trunk

508fe07a 03/16/2009 01:23 PM Ronald S. Bultje

More reindent, forgotten in previous commit.

Originally committed as revision 18014 to svn://svn.ffmpeg.org/ffmpeg/trunk

2d6f3014 03/16/2009 01:03 PM Ronald S. Bultje

Parse index chunk so that seeking in modern .rm files becomes a lot faster.
Has been tested against streamed / non-seekable input and passes make
seektest. See "[PATCH] rmdec.c: parse INDX chunk" thread on mailinglist.

Originally committed as revision 18013 to svn://svn.ffmpeg.org/ffmpeg/trunk

c8829279 03/16/2009 01:01 PM Ronald S. Bultje

Reindent after r18010.

Originally committed as revision 18011 to svn://svn.ffmpeg.org/ffmpeg/trunk

55d330f9 03/16/2009 12:59 PM Ronald S. Bultje

Mark the first output audio frame as keyframe (separate patch from previous,
as requested by Kostya). See "[PATCH] rmdec.c: remove cache access
duplication".

Originally committed as revision 18010 to svn://svn.ffmpeg.org/ffmpeg/trunk

c5efef7b 03/16/2009 12:57 PM Ronald S. Bultje

Remove packet returning in ff_rm_parse_packet() if we're using the packet
cache, since this can already be accessed through ff_rm_retrieve_cache().
See "[PATCH] rmdec.c: remove cache access duplication" thread.

Originally committed as revision 18009 to svn://svn.ffmpeg.org/ffmpeg/trunk

7268f0bd 03/16/2009 12:50 PM Ronald S. Bultje

Reindent after r18005.

Originally committed as revision 18007 to svn://svn.ffmpeg.org/ffmpeg/trunk

6a2d3fc3 03/16/2009 12:47 PM Ronald S. Bultje

Merge code for packet reading in "old" (.ra, audio-only) Realmedia files and
the newer (.rm, audio/video) files. See "[PATCH] rmdec.c: merge old/new
packet reading code" thread on mailinglist.

Originally committed as revision 18005 to svn://svn.ffmpeg.org/ffmpeg/trunk

f05783c2 03/16/2009 06:46 AM Baptiste Coudurier

cosmetics, remove useless braces

Originally committed as revision 18004 to svn://svn.ffmpeg.org/ffmpeg/trunk

9bf1b268 03/16/2009 06:46 AM Baptiste Coudurier

simplify printing

Originally committed as revision 18003 to svn://svn.ffmpeg.org/ffmpeg/trunk

f584386d 03/16/2009 06:44 AM Baptiste Coudurier

reindent

Originally committed as revision 18002 to svn://svn.ffmpeg.org/ffmpeg/trunk

c6026e43 03/16/2009 06:43 AM Baptiste Coudurier

fix trkn metadata parsing

Originally committed as revision 18001 to svn://svn.ffmpeg.org/ffmpeg/trunk

0fb44a4e 03/16/2009 06:06 AM Baptiste Coudurier

move read_udta_string up to avoid forward declaration

Originally committed as revision 18000 to svn://svn.ffmpeg.org/ffmpeg/trunk

873358e5 03/16/2009 06:03 AM Baptiste Coudurier

more generic metadata handling

Originally committed as revision 17999 to svn://svn.ffmpeg.org/ffmpeg/trunk

2229a5c6 03/16/2009 05:13 AM Baptiste Coudurier

do not set isom if ctype is not set, happens in mov

Originally committed as revision 17998 to svn://svn.ffmpeg.org/ffmpeg/trunk

df8843c6 03/15/2009 11:54 PM Baptiste Coudurier

search for hdlr atom in meta, some files do not store version+flags

Originally committed as revision 17996 to svn://svn.ffmpeg.org/ffmpeg/trunk

7a160bca 03/15/2009 08:14 PM Ronald S. Bultje

Fix index generation in the way that it was supposed to be used. See the
discussion in the ML thread "[PATCH] rmdec.c: merge old/new packet reading
code".

Over time, this code broke somewhat, e.g. seq was never actually written
into (and was thus always 1, therefore the seq condition was always true),...

7c4502c8 03/15/2009 10:53 AM Baptiste Coudurier

typo in the mail, the 4am commit is always the worst

Originally committed as revision 17981 to svn://svn.ffmpeg.org/ffmpeg/trunk

4909e517 03/15/2009 10:49 AM Baptiste Coudurier

cosmetics

Originally committed as revision 17980 to svn://svn.ffmpeg.org/ffmpeg/trunk

983bdd37 03/15/2009 10:49 AM Baptiste Coudurier

add my copyright in mov de/muxer

Originally committed as revision 17979 to svn://svn.ffmpeg.org/ffmpeg/trunk

e49da827 03/15/2009 09:44 AM Baptiste Coudurier

allocate palette in codec directly

Originally committed as revision 17976 to svn://svn.ffmpeg.org/ffmpeg/trunk

6c00a9de 03/15/2009 09:06 AM Baptiste Coudurier

cosmetics, add some whitespaces and empty lines

Originally committed as revision 17975 to svn://svn.ffmpeg.org/ffmpeg/trunk

f0f2218d 03/15/2009 07:21 AM Baptiste Coudurier

do not modify sample_count, check against index entries

Originally committed as revision 17972 to svn://svn.ffmpeg.org/ffmpeg/trunk

ed6ae6a5 03/14/2009 11:39 PM Baptiste Coudurier

use utc time for timestamp and do not set it if not specified

Originally committed as revision 17971 to svn://svn.ffmpeg.org/ffmpeg/trunk

36a12218 03/14/2009 10:51 PM Baptiste Coudurier

swf timestamps are 16 bits

Originally committed as revision 17969 to svn://svn.ffmpeg.org/ffmpeg/trunk

40a1d41f 03/14/2009 10:49 PM Baptiste Coudurier

remove unused fields in swf context

Originally committed as revision 17968 to svn://svn.ffmpeg.org/ffmpeg/trunk

2261a952 03/14/2009 10:43 PM Baptiste Coudurier

do not parse timestamp if bitexact is set, should fix regression tests

Originally committed as revision 17967 to svn://svn.ffmpeg.org/ffmpeg/trunk

881dad9e 03/14/2009 10:07 PM Reimar Döffinger

Enable generic index creation and seeking for NUV demuxer.

Originally committed as revision 17966 to svn://svn.ffmpeg.org/ffmpeg/trunk

74f5ae84 03/14/2009 09:46 PM Reimar Döffinger

Add AVFMT_GENERIC_INDEX support also for formats that do not use a parser.

Originally committed as revision 17965 to svn://svn.ffmpeg.org/ffmpeg/trunk

bd36f175 03/14/2009 08:50 PM Reimar Döffinger

Make pcm_read_seek treat negative time stamps as 0, this avoids incorrectly
seeking before data_offset and is more consistent with how the generic index
seeking code handles it.

Originally committed as revision 17964 to svn://svn.ffmpeg.org/ffmpeg/trunk

85b4230f 03/14/2009 04:30 PM Michael Niedermayer

Do not lose user flags when passing calls from the new to the old seeking API.

Originally committed as revision 17959 to svn://svn.ffmpeg.org/ffmpeg/trunk

32d88592 03/14/2009 03:51 PM Michael Niedermayer

add avformat_seek_file()

Originally committed as revision 17956 to svn://svn.ffmpeg.org/ffmpeg/trunk

7e04cfba 03/13/2009 10:26 PM Reimar Döffinger

Set pkt->pos correctly (to the start of header of the packet) in swfdec.

Originally committed as revision 17953 to svn://svn.ffmpeg.org/ffmpeg/trunk

4e35ffa9 03/13/2009 07:37 PM Baptiste Coudurier

fix swf seeking by fixing new stream detection

Originally committed as revision 17952 to svn://svn.ffmpeg.org/ffmpeg/trunk

abb785f1 03/13/2009 01:37 PM Reimar Döffinger

Simplify RoQ demuxer pts calculation by using a appropriate time bases.

Originally committed as revision 17946 to svn://svn.ffmpeg.org/ffmpeg/trunk

15969b55 03/12/2009 11:47 AM Reimar Döffinger

Set video width/height and create audio stream in read_packet instead of
pre-parsing the file in read_header.
This avoids some code duplication and seeking, and also avoids an IO error
for small video-only files (as created during e.g. the FATE encoder test)....

d168b3fd 03/11/2009 08:05 AM Baptiste Coudurier

reindent

Originally committed as revision 17940 to svn://svn.ffmpeg.org/ffmpeg/trunk

7943a90a 03/11/2009 08:04 AM Baptiste Coudurier

keep original tag when stream copying subs with ipod format

Originally committed as revision 17939 to svn://svn.ffmpeg.org/ffmpeg/trunk

c569bd06 03/11/2009 08:03 AM Baptiste Coudurier

ipod supports both subs tags

Originally committed as revision 17938 to svn://svn.ffmpeg.org/ffmpeg/trunk

80357cfc 03/11/2009 08:02 AM Baptiste Coudurier

reindent

Originally committed as revision 17937 to svn://svn.ffmpeg.org/ffmpeg/trunk

9f520554 03/11/2009 08:01 AM Baptiste Coudurier

write correct atoms based on tag and not format, fixes subs stream copy

Originally committed as revision 17936 to svn://svn.ffmpeg.org/ffmpeg/trunk

d1df4da0 03/11/2009 07:59 AM Baptiste Coudurier

use correct codec tag list for ipod format

Originally committed as revision 17935 to svn://svn.ffmpeg.org/ffmpeg/trunk

f344ae80 03/11/2009 06:48 AM Baptiste Coudurier

again 10l, typo, put_byte instead of put_buffer

Originally committed as revision 17933 to svn://svn.ffmpeg.org/ffmpeg/trunk

cafdc187 03/11/2009 06:15 AM Baptiste Coudurier

attempt to try to generate an random umid

Originally committed as revision 17932 to svn://svn.ffmpeg.org/ffmpeg/trunk

a2523ce2 03/11/2009 06:04 AM Baptiste Coudurier

fix subs track height, set track->height to codec height if not set

Originally committed as revision 17929 to svn://svn.ffmpeg.org/ffmpeg/trunk

3596f4e0 03/11/2009 01:36 AM Ben Littler

sn40 avi fourcc decodes with ffodivx

Originally committed as revision 17928 to svn://svn.ffmpeg.org/ffmpeg/trunk

b5b9ff2a 03/10/2009 12:55 PM Ronald S. Bultje

Correctly skip complete INDX chunks, i.e. read the 32-bit header correctly
and if the size is broken (20 bytes, header-only), calculate the expected
size and skip the index entries anyway. See "[PATCH] rmdec.c: correctly
skip indexes" thread.

Originally committed as revision 17924 to svn://svn.ffmpeg.org/ffmpeg/trunk

b8cc5a9f 03/09/2009 10:03 PM Ronald S. Bultje

Prevent (negative) overflow of rm->remaining_len. This evaluation really only
has two possible outcomes: either len and rm->remaining_len are the same, in
which case we care about the outcome and it is zero, or rm->remaining_len is
currently not in use and we don't care about the outcome. In that case, len...

7ccefd08 03/09/2009 10:02 PM Ronald S. Bultje

Revert to r17908.

Originally committed as revision 17918 to svn://svn.ffmpeg.org/ffmpeg/trunk

88c4339b 03/09/2009 09:53 PM Ronald S. Bultje

Move MOVContext and related structures from mov.c to isom.h. See "[PATCH]
move MOVContext from mov.c to isom.h" thread on ML.

Originally committed as revision 17915 to svn://svn.ffmpeg.org/ffmpeg/trunk

3898eed8 03/09/2009 05:47 PM Reimar Döffinger

Reorder arguments for av_fifo_generic_read to be more logical and
consistent with av_fifo_generic_write.

Originally committed as revision 17914 to svn://svn.ffmpeg.org/ffmpeg/trunk

0ecf9cc9 03/09/2009 01:08 PM Ronald S. Bultje

Prevent (negative) overflow of rm->remaining_len. This evaluation really only
has two possible outcomes: either len and rm->remaining_len are the same, in
which case we care about the outcome and it is zero, or rm->remaining_len is
currently not in use and we don't care about the outcome. In that case, len...