« Previous | Next » 

Revision 9b2283cc

ID9b2283cc3352b1f446814f0c6fa5230978b9ee78
Parent ee7388c9
Child ea395e8c

Added by Stefan Huehner over 15 years ago

Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Originally committed as revision 17567 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences