Revision dd597cd7 doc/ffmpeg-doc.texi

View differences:

doc/ffmpeg-doc.texi
1623 1623
Also please if you send several patches, send each patch as seperate mail,
1624 1624
dont attach several unrelated patches to the same mail.
1625 1625

  
1626
@section patch submission checklist
1627

  
1628
@enumerate
1629
@item
1630
    Do the regression tests pass with the patch applied?
1631
@item
1632
    Is the patch a unified diff?
1633
@item
1634
    Is the patch against latest ffmpeg SVN?
1635
@item
1636
    Are you subscribed to ffmpeg-dev?
1637
    (the list is subscribers only due to spam)
1638
@item
1639
    Have you checked that the changes are minimal, so that the same cannot be
1640
    achived with a smaller patch and/or simpler final code?
1641
@item
1642
    If the change is to speed critical code did you benchmark it?
1643
@item
1644
    Have you checked that the patch does not intruduce buffer overflows or
1645
    other security issues?
1646
@item
1647
    Is the patch made from the root of the source, so it can be applied with -p0?
1648
@item
1649
    Does the patch not mix functional and cosmetic changes?
1650
@item
1651
    Is the patch attached to the email you send?
1652
@item
1653
    Is the mime type of the patch correct? (not application/octet-stream)
1654
@item
1655
    If the patch fixes a bug did you provide a verbose analysis of the bug?
1656
@item
1657
    If the patch fixes a bug did you provide enough information including
1658
    a sample, so the bug can be reproduced and the fix can be verified?
1659
@item
1660
    Did you provide a verbose summary about what the patch does change?
1661
@item
1662
    Did you provide a verbose explanation why it changes things like it does?
1663
@item
1664
    Did you provide a verbose summary of the user vissible advantages and
1665
    disadvantages if the patch is applied?
1666
@item
1667
    Did you provide an example so we can verify the new feature added by the
1668
    patch easily?
1669
@item
1670
    If you did any benchmarks, did you provide them in the mail?
1671
@end enumerate
1672

  
1626 1673
@section Patch review process
1627 1674

  
1628 1675
All patches posted to ffmpeg-devel will be reviewed, unless they contain a

Also available in: Unified diff